Constrain content paths to the content root. - #99
Merged
Conversation
Assisted-By: devx/cbdeae41-9308-4071-ad53-58cd92db2946
Assisted-By: devx/cbdeae41-9308-4071-ad53-58cd92db2946
samuel-williams-shopify
force-pushed
the
constrain-content-local-path
branch
from
August 17, 2026 08:43
4c2b8bf to
9345f01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve
Utopia::Content::Node#local_paththroughProtocol::URL::Path#local_path, ensuring application paths remain lexically contained beneath the configured content root.Preserve the existing
Pathnamereturn type and relative-path behavior. Reject absolute paths containing traversal which would escape the root.This boundary does not resolve symbolic links or protect against filesystem races; it provides the same lexical containment used by static file serving.
Testing
bundle exec sus test/utopia/content.rb test/utopia/content/node.rbbundle exec rubocop lib/utopia/content/node.rb test/utopia/content/node.rbbundle exec bake decode:index:coverage lib