Skip to content

async generators wip#16

Merged
heapwolf merged 4 commits intomasterfrom
async-async-generators
Jul 3, 2019
Merged

async generators wip#16
heapwolf merged 4 commits intomasterfrom
async-async-generators

Conversation

@heapwolf
Copy link
Copy Markdown
Collaborator

@heapwolf heapwolf commented Jul 3, 2019

This PR allows the render function to be async or async *, for example...

class FooBar extends Tonic {
  async * render () {
    yield "Loading..."
    yield await getData()
  }
}

However, it is not yet possible to test correctly since @juliangruber's tape-run module does not support a current browser.

cc @davidmarkclements

@heapwolf heapwolf requested a review from juliedavila July 3, 2019 21:06
Comment thread index.js Outdated
Comment thread index.js Outdated
Comment thread package.json
@heapwolf
Copy link
Copy Markdown
Collaborator Author

heapwolf commented Jul 3, 2019

I think this could be published as @conductorlab/tonic@next and then once the tests are passing again it could be published normally.

@heapwolf heapwolf merged commit b9bc204 into master Jul 3, 2019
@heapwolf heapwolf deleted the async-async-generators branch February 19, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants