[Python] Add checks when parsing RegressionStateScenes.regression-tests file - #121
Merged
alxbilger merged 1 commit intoJul 29, 2026
Merged
Conversation
Contributor
|
Check for conflicts with #118. I made this PR also to handle the |
Contributor
Author
|
Akshually, it is #118 which makes because values[1] in this case instead of being a number of steps (as it should be) is an epsilon (1e-8). Python throws ValueError exception in this case. |
Contributor
|
I suggest to go with json in the future |
alxbilger
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the SOFA codebase, the regression was crashing for
FEMBAR_ShewchukPCGLinearSolver.scnbecause the RegressionStateScenes.regression-tests is missing an argument (nb of steps) for this scene. Apparently the C++ version is not bothered....