[FIX] The callpoint api is broken since SofaPython3. #271
Merged
damienmarchal merged 6 commits intosofa-framework:masterfrom Jun 23, 2022
Merged
[FIX] The callpoint api is broken since SofaPython3. #271damienmarchal merged 6 commits intosofa-framework:masterfrom
damienmarchal merged 6 commits intosofa-framework:masterfrom
Conversation
damienmarchal
force-pushed
the
pr-fix-callpoint-api
branch
from
4855cd9 to
8b597ec
Compare
damienmarchal
force-pushed
the
pr-fix-callpoint-api
branch
from
8b597ec to
f43c367
Compare
damienmarchal
added
issue: bug
damienmarchal
force-pushed
the
pr-fix-callpoint-api
branch
from
fdd678c to
c498333
Compare
Contributor
|
@damienmarchal Could you solve the conflicts? |
In python3 the path are not absolute so it is needed to ask for.
Contributor
Author
|
Conflict solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In runSofa,
it is possible to get where the object has been instanciated in the scene from the scenegraph. This was working in both python2 and xml.
This was broken with SofaPython3 so the "Go Scene" popup menu entry is always grayed out.
The PR restore the behavior.
NB: for complex python scene it would be better to have the full creation stack instead of just the last line... but this may be an interesting UX improvement but outside of the scope of this PR.