[SceneChecking] MissingRequiredPlugins: Adapts messages for xml and python users#3033
[SceneChecking] MissingRequiredPlugins: Adapts messages for xml and python users#3033EulalieCoevoet wants to merge 2 commits intosofa-framework:masterfrom
Conversation
|
Thanks @EulalieCoevoet for this nice contribution. It is still unclear to me if instead of having the extension passed by changing the SceneChecker API it would not be a better to use Base::getInstanciationSourceFileName(). @alxbilger, what is your opinion ? [ci-build][with-scene-tests] |
|
Sure, if such method exists I should use that. Thanks for pointing it out. |
|
Yes the method exists... but, contrary to the XML loader, the SofaPython3 scene loader does not use the setInstanciationSourceFileName to set the filename associated with the root node. EDIT: I made a quick pr to for SofapythoN3: sofa-framework/SofaPython3#271 |
|
This is how I would do it:
I admit this is quite complex to do. The reason is that all the scene checkers are all grouped in the same module, and In any case, I am uncomfortable with the idea to have a scene checker for Python in the core. Somehow, it should be in SofaPython3. Another case to support is simpleapi :) |
|
Let's close this PR. I'll do another one with Alex's suggestion when I have time. |
|
Too bad, I was just searching for this feature and discovered it was not integrated. |
This PR improves the message about missing required plugins for python users. Before it was printing lines to cut and paste in the scene (which is really nice!), but only for xml users. Now I propose to check the scene's extension and adapt the message.
Here's an example for python:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if