Fix SOFAPYTHON_PLUGINS_PATH env var with Windows (and add a warning error)#349
Merged
alxbilger merged 4 commits intosofa-framework:masterfrom Jun 14, 2023
Merged
Conversation
alxbilger
reviewed
May 11, 2023
alxbilger
reviewed
May 11, 2023
Contributor
alxbilger
left a comment
alxbilger
left a comment
There was a problem hiding this comment.
In the case both environment variables are found, I think you pick the deprecated one in priority. I am not sure we want that. I would add the condition that the new environment variable is not found
alxbilger
approved these changes
Jun 13, 2023
damienmarchal
pushed a commit
that referenced
this pull request
Sep 13, 2024
…rror) (#349) * Fix handling env var sp3pluginpath with windows * more info in the message * use sofapy3_plugins_path if both are set * fix compil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and deprecate it in favor of SOFAPYTHON3_PLUGINS_PATH to be more consistent with the other names.
Use
system::FileRepositoryinstead of manually handle the content of the env var.Especially that it was not handling the correct separating marker for Windows (which is ";" instead of ":" apparently)
PLUS
Added a message when the path given to
addPythonModulePathis not correct.This actually happens often, e.g BeamAdapter/Cosserat did not update their cmake config when the python3 was renamed.
With Cosserat you get
Added 'D:/sofa/src/plugins/CosseratPlugin/python' to sys.patheven if the directory does not exist.