Fix vs2017 build - #61
Merged
Merged
Conversation
Contributor
None I guess, probably a bad copy/paste on my part. The only important thing is the |
Contributor
|
Hum, the CI cannot find the tests anymore. I guess you do need the install(EXPORT ...). Edit: |
jnbrunet
reviewed
Nov 1, 2020
|
|
||
| if(MSVC) | ||
| # define BOOST_ALL_DYN_LINK needed for dynamic linking with boost libraries | ||
| add_definitions(-DBOOST_ALL_DYN_LINK) |
Contributor
There was a problem hiding this comment.
Not needed anymore, see sofa-framework/sofa#1578
Contributor
Author
|
Test failures are not my fault anymore! 👼 |
Contributor
Author
|
Please merge me! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bunch of changes I had to do to be able to configure and build SofaPython3 on my machine.
I am not sure about the last commit. What is the point of
install(EXPORT ...on tests?