Fix tests - #65
Merged
Merged
Conversation
Contributor
|
Totally not an expert of SofaPython 🦸♂️ but fixing the test(s) by removing some of them is okay ? |
Contributor
Author
In this case this is a "sugar" feature, ie it is not binding an actual SOFA API feature. And this feature doesn't work at the moment. Hence the removal. Any PR that fix this feature and put it back with a functional test is welcome, but for now we need to go forward if we want a stable CI and release soon. |
SofaComponentAll was mostly used to load kernel components (SofaBase, SofaSimulation and SofaCore). These are not yet pluginized. The idea with this commit is to remove the dependency of SofaComponentAll which loads much more than the kernel components, and replace it with hard link dependencies until we finish the pluginization of the SOFA kernel.
SOFA minimal binaries are lightweights are it is taking about the same time to download and install them compared to the caching system. This will simplify CI workflows.
jnbrunet
added
pr: status wip
pr: status ready
and removed
pr: status to review
pr: status wip
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.