Skip to content

[Visual] Compute bounding box in VisualMesh#5985

Merged
fredroy merged 4 commits intosofa-framework:masterfrom
alxbilger:bboxvisualmesh
Mar 10, 2026
Merged

[Visual] Compute bounding box in VisualMesh#5985
fredroy merged 4 commits intosofa-framework:masterfrom
alxbilger:bboxvisualmesh

Conversation

@alxbilger
Copy link
Copy Markdown
Contributor


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger requested a review from fredroy March 2, 2026 14:20
@alxbilger alxbilger added pr: enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Mar 2, 2026
Copy link
Copy Markdown
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should computeBBox() compute BBox if:

  • computeOnlyVisible is true (meaning computeBBox was called for rendering)
  • vparams->displayFlags().getShowVisualModels() is false ?

?

Comment thread Sofa/Component/Visual/src/sofa/component/visual/VisualMesh.cpp Outdated
Comment thread Sofa/Component/Visual/src/sofa/component/visual/VisualMesh.cpp
@alxbilger alxbilger requested a review from fredroy March 10, 2026 13:04
@fredroy fredroy merged commit 38fd700 into sofa-framework:master Mar 10, 2026
12 of 13 checks passed
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants