Skip to content

[Core] Fix MeshLoader parse method when calling super method#6029

Merged
th-skam merged 2 commits intosofa-framework:masterfrom
alxbilger:meshloadersuper
Mar 19, 2026
Merged

[Core] Fix MeshLoader parse method when calling super method#6029
th-skam merged 2 commits intosofa-framework:masterfrom
alxbilger:meshloadersuper

Conversation

@alxbilger
Copy link
Contributor

The following scene does not generate any mesh:

<Node name="root">
    <StringMeshCreator name="string"/>
</Node>

It's because the parse method in MeshLoader does not call the parse method from its direct parent, but from BaseObject.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Mar 17, 2026
@bakpaul bakpaul added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Mar 19, 2026
@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 19, 2026
@th-skam th-skam merged commit e7b2070 into sofa-framework:master Mar 19, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants