Skip to content

[Tracy] Fix compilation when enabling Tracy#6031

Merged
fredroy merged 4 commits intomasterfrom
25_03_fix_compilation_of_perf_tests
Mar 19, 2026
Merged

[Tracy] Fix compilation when enabling Tracy#6031
fredroy merged 4 commits intomasterfrom
25_03_fix_compilation_of_perf_tests

Conversation

@bakpaul
Copy link
Copy Markdown
Contributor

@bakpaul bakpaul commented Mar 18, 2026

Compilation was broken from #6019 because it is not tested on the CI. It was broken because the way tracy's timers are used in SOFA, they require only constexpr names to be used. A dynamic equivalent exists but at the cost of having some overhead in execution time.

My solution is to add two new time macro for dynamic names. They do the same when Tracy is off, but will use the 'transient' version of Tracy.

I saw it actually because the performance tests are broken since this commit, and the reason is that they are using Tracy... I tested this Pr on the builder and it fixes this CI.

Here is the resource that helped me wolfpld/tracy#103


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Mar 18, 2026
@fredroy fredroy force-pushed the 25_03_fix_compilation_of_perf_tests branch from 0fbe1c5 to 0abed63 Compare March 18, 2026 22:44
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 19, 2026
@fredroy fredroy merged commit 981e53a into master Mar 19, 2026
19 of 23 checks passed
@fredroy fredroy deleted the 25_03_fix_compilation_of_perf_tests branch March 19, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants