Skip to content

[SofaCUDA] CMake: Remove old options#6079

Merged
epernod merged 5 commits intosofa-framework:masterfrom
fredroy:clean_cublas
Apr 23, 2026
Merged

[SofaCUDA] CMake: Remove old options#6079
epernod merged 5 commits intosofa-framework:masterfrom
fredroy:clean_cublas

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Apr 13, 2026

First intention was to fix the cmake configure process with cuBLAS activated (it was missing the PUBLIC keyword)

But then cuBLAS and THRUST are fully integrated into CudaToolkit, which is a requirement for SofaCUDA ; and I guess it came from the time it was not supported by all the GPUs
So IMO it should always be enabled.

Same for double, but I am not 100% sure about it, as one may not want the double version maybe.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Apr 13, 2026
@bakpaul
Copy link
Copy Markdown
Contributor

bakpaul commented Apr 16, 2026

I would prefer to leave the possibility to deactivate the DOUBLE compilation. So IMO, let's keep the option but put it to on by default.

@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 23, 2026
@epernod epernod merged commit c463297 into sofa-framework:master Apr 23, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants