Skip to content

[Mapping] SkinningMapping: compute weights from position#6080

Merged
fredroy merged 1 commit intosofa-framework:masterfrom
EulalieCoevoet:pr_skinningmapping
Apr 17, 2026
Merged

[Mapping] SkinningMapping: compute weights from position#6080
fredroy merged 1 commit intosofa-framework:masterfrom
EulalieCoevoet:pr_skinningmapping

Conversation

@EulalieCoevoet
Copy link
Copy Markdown
Contributor

By default, the weights of the SkinningMapping are computed w.r.t the rest position of the input model.
This PR adds an option to compute them from the position instead.

For exemple, I'm using this with pre-bent concentric tubes: the rest position is curved, while the visual model and position at start are straight.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@EulalieCoevoet EulalieCoevoet added the pr: enhancement About a possible enhancement label Apr 14, 2026
@fredroy fredroy added the pr: status to review To notify reviewers to review this pull-request label Apr 15, 2026
@th-skam th-skam added pr: status ready Approved a pull-request, ready to be squashed pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: status to review To notify reviewers to review this pull-request labels Apr 16, 2026
@fredroy fredroy force-pushed the pr_skinningmapping branch from dce2936 to bb6476e Compare April 17, 2026 05:30
@fredroy fredroy merged commit c5e35b6 into sofa-framework:master Apr 17, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants