[Example] Convert Torusfall XML scene to SofaPython3 scene#6089
Open
fredroy wants to merge 2 commits intosofa-framework:masterfrom
Open
[Example] Convert Torusfall XML scene to SofaPython3 scene#6089fredroy wants to merge 2 commits intosofa-framework:masterfrom
fredroy wants to merge 2 commits intosofa-framework:masterfrom
Conversation
Contributor
|
[ci-build][with-all-tests] |
Contributor
|
I am sorry to intervene on this PR after the SOFA dev meeting. |
Contributor
|
@bakpaul how to add it in the PerformanceRegressionTests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to test different solver or model for each torus but it was a pain in the xml file to apply to all the toruses.
Moreover it was quite unreadable because of the length of the scene, the long strings, etc.
So I ask Claude to rewrite and refactor in python
The cylinders part can be customized (increasing/decreasing the numbers).
I wanted to do the same with the toruses but it was a pain to find a programmatically way to compute them so I let as it is for now.
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if