[Sofa.GL] DrawtoolGL: Auto-scale indices display based on camera distance#6092
Open
fredroy wants to merge 1 commit intosofa-framework:masterfrom
Open
[Sofa.GL] DrawtoolGL: Auto-scale indices display based on camera distance#6092fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy wants to merge 1 commit intosofa-framework:masterfrom
Conversation
The indices text now maintains a constant screen-space size regardless of zoom level and scene dimensions, removing the need to manually adjust showIndicesScale per scene. - Compute per-vertex scale from the projection matrix and camera depth in GlText::textureDraw_Indices - Handle both perspective and orthographic projections - Add alpha blending for smoother text rendering - Update all callers to pass a dimensionless multiplier (default 1.0) instead of bbox-dependent world-space size
hugtalbot
requested changes
Apr 24, 2026
Contributor
hugtalbot
left a comment
There was a problem hiding this comment.
"Scaling factor" instead of "Multiplier" ?
Else OK to me
alxbilger
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The indices are rendered independently of the size of the scene (bbox) and zoom.
Now the size is determined by screen space, i.e it will always show the same size, no matter the zoom.
Breaking side-effect: the side-car parameter, scale (like
showIndicesScaleof the mechanical object, is now defaultted to 1.Default pixel-size is set to 30 but I guess it could be tweaked if the reviewers want.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if