Skip to content

[Visual] VisualModelImpl: add data to optionally generate uv coords#6137

Merged
hugtalbot merged 2 commits into
sofa-framework:masterfrom
fredroy:visualmodel_avoid_uvcompute
Jun 12, 2026
Merged

[Visual] VisualModelImpl: add data to optionally generate uv coords#6137
hugtalbot merged 2 commits into
sofa-framework:masterfrom
fredroy:visualmodel_avoid_uvcompute

Conversation

@fredroy

@fredroy fredroy commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

... using UV spherical projection.

This was done automatically if there was no texcoords previously (most certainly from a mesh).
But more often than not, the texcoords are not used so this is wasteful.

same as the previous PR, this is "functionally" breaking because it changes an implicit behavior to an explicit one (with an opposite default value), but I dont want to nag with message like "it was generating texcoords before, if you want to to do it set the data blabalbla"

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 2, 2026
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 11, 2026
@hugtalbot hugtalbot merged commit 71cb8a4 into sofa-framework:master Jun 12, 2026
13 checks passed
@hugtalbot hugtalbot deleted the visualmodel_avoid_uvcompute branch June 12, 2026 05:38
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants