Skip to content

[Type] Remove VecView class and update codebase to use Vec utilities instead#6138

Merged
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:removevecview
Jun 12, 2026
Merged

[Type] Remove VecView class and update codebase to use Vec utilities instead#6138
fredroy merged 1 commit into
sofa-framework:masterfrom
alxbilger:removevecview

Conversation

@alxbilger

Copy link
Copy Markdown
Contributor

Benchmarks show that VecView is slower than using a Vec copy. However, VecView had the advantage to be more elegant and concise. To remove VecView, this PR introduces setsub in Vec. Note that this is consistent with the getsub method, and that Mat has also getsub and setsub.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 3, 2026
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 11, 2026
@fredroy fredroy merged commit a2c0720 into sofa-framework:master Jun 12, 2026
10 of 13 checks passed
@hugtalbot hugtalbot added this to the v26.06 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants