VM restructure and refactor - #17
Merged
Merged
Conversation
DiegoCivi
approved these changes
Jun 17, 2025
DiegoCivi
left a comment
There was a problem hiding this comment.
Looks good! Just a little comment. Since getting the PC is very common, maybe you could implement the method vm.get_pc() so you avoid doing vm.registers[PC.usize()] all the time.
This was referenced Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some restructuring of the VM. The major changes are:
utils.rsfile for functionsread_file,get_charanddisable_input_buffering.VMStateto its own file and make functionsmem_read,mem_writeandwrite_ixs_to_mempart of its methods implementation.get_charutil function in TRAP handles.