Fix exportmsg#221
Merged
Merged
Conversation
Member
|
This looks fine to me. Can we get a bit more detail into the commit messages, and also rebase against master? |
Fixes #164. The old code for this was a bit messy, which lead in some cases to runtime errors. This cleans up the code and fixes those issues.
ptersilie
force-pushed
the
fix_exportmsg
branch
from
2778494 to
a2e8bfe
Compare
Member
Author
|
Updated the commits messages! |
ltratt
reviewed
Sep 20, 2018
| self.emit(self.signal_execute_fail, "program syntactically invalid") | ||
| else: | ||
| for line in iter(p.stdout.readline, b''): | ||
| if lang == "PHP + Python": |
Member
Author
|
Addressed your comment. Let me know when I should squash! |
Member
|
Works for me. Please squash. |
ptersilie
force-pushed
the
fix_exportmsg
branch
from
c5dda07 to
2c9485d
Compare
Member
Author
|
Squashed! |
Fixes #159. Instead of a popup dialog, use Eco's console to display error messages when executing programs from within Eco. Also distinguish between different error reasons like invalid syntax, missing binaries, or missing paths.
Merged
ltratt
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues #164 and #159.
To be honest, the execution code is a bit of a mess, but I don't believe it's worth a rewrite given we will be moving to Eco2 soon. So I just tried to fix it without touching too much code.