Skip to content

Conversation

@iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Sep 26, 2025

Also exporting isVariable and type Namespace, since they weren't before

@iwoplaza iwoplaza marked this pull request as ready for review September 26, 2025 11:31
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@a76e95123bfadd00c0c2f24c161ec8db3ef5749d
https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@a76e95123bfadd00c0c2f24c161ec8db3ef5749d
https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@a76e95123bfadd00c0c2f24c161ec8db3ef5749d

benchmark
view benchmark

commit
view commit

Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just try to improve the error @cieplypolar mentioned

@cieplypolar
Copy link
Collaborator

cieplypolar commented Sep 26, 2025

  it('should throw descriptive error', () => {
    const main = (a: number) => {
      'kernel';
      return a + 1;
    };
    expect(() => asWgsl(main)).toThrowErrorMatchingInlineSnapshot(`
      [Error: Resolution of the following tree failed:
      - <root>
      - (a) => {
            "kernel";
            return a + 1;
          }
      - fn*:item_0: Identifier a not found]
    `);
  });

It should throw more descriptive error. I would expect Cannot infer argument type or something like that.

Apart from that awesome work 🚀

@iwoplaza iwoplaza merged commit 0897d0f into main Sep 27, 2025
5 of 6 checks passed
@iwoplaza iwoplaza deleted the feat/resolve-shell-less branch September 27, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants