Skip to content

fix: not filtering builtin outputs out of the fragment shader #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iwoplaza merged 1 commit into from
Oct 3, 2025
Merged

fix: not filtering builtin outputs out of the fragment shader #1779

iwoplaza merged 1 commit into from
Oct 3, 2025

Conversation

@lursz
Copy link
Contributor

@lursz lursz commented Oct 3, 2025

fixes: #1778

@lursz lursz requested review from iwoplaza and reczkok October 3, 2025 14:23
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

pkg.pr.new

packages
Ready to be installed by your favorite package manager ⬇️

https://pkg.pr.new/software-mansion/TypeGPU/typegpu@d20f1d7786cbcd342c2b1d80a3317d37ea43287d

https://pkg.pr.new/software-mansion/TypeGPU/@typegpu/noise@d20f1d7786cbcd342c2b1d80a3317d37ea43287d

https://pkg.pr.new/software-mansion/TypeGPU/unplugin-typegpu@d20f1d7786cbcd342c2b1d80a3317d37ea43287d

benchmark
view benchmark

commit
view commit

iwoplaza
iwoplaza approved these changes Oct 3, 2025
View reviewed changes
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🫡

@iwoplaza iwoplaza merged commit 6b1268b into main Oct 3, 2025
5 checks passed
@iwoplaza iwoplaza deleted the fix/builtin-not-filtering branch October 3, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iwoplaza iwoplaza iwoplaza approved these changes

@reczkok reczkok Awaiting requested review from reczkok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: not filtering builtin outputs out of the fragment shader

3 participants

@lursz @iwoplaza