fix: Giving local declarations unique names if they clash with global declarations, and vice-versa + 'strict' the default naming scheme in pipelines #2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
Comment on lines
+249
to
+252
| return this | ||
| .#usedFunctionScopeNamesStack[ | ||
| this.#usedFunctionScopeNamesStack.length - 1 | ||
| ]; |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| return this | |
| .#usedFunctionScopeNamesStack[ | |
| this.#usedFunctionScopeNamesStack.length - 1 | |
| ]; | |
| return this.#usedFunctionScopeNamesStack.at(-1); |
cieplypolar
reviewed
Dec 23, 2025
| if (global) { | ||
| this.#usedNames.add(name); | ||
| } else { | ||
| this.usedFunctionScopeNames?.add(name); |
Collaborator
There was a problem hiding this comment.
I don't like the fact that the function scope stack can be empty. I’d prefer to add an invariant (it is never empty) or a comment explaining why this state is possible
| makeValid(primer: string): string { | ||
| if (isValidIdentifier(primer)) { | ||
| if (isValidIdentifier(primer) && !this.#usedNames.has(primer)) { | ||
| this.usedFunctionScopeNames?.add(primer); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.