Merged
Conversation
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (326 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
|
pkg.pr.new packages benchmark commit |
aleksanderkatan
requested review from
cieplypolar,
iwoplaza,
lursz and
reczkok
cieplypolar
reviewed
Jan 16, 2026
| }); | ||
| expect(tgpu.resolve([myFunction])).toMatchInlineSnapshot(` | ||
| "fn myFunction() { | ||
| ; |
Collaborator
There was a problem hiding this comment.
simple check at the end of statement method will handle this single ;.
iwoplaza
approved these changes
Jan 16, 2026
| const consequent = transpile(ctx, node.consequent) as tinyest.Expression; | ||
| const alternative = transpile(ctx, node.alternate) as tinyest.Expression; | ||
|
|
||
| return [NODE.conditionalExpr, test, consequent, alternative]; |
Collaborator
There was a problem hiding this comment.
IMO we should call it "conditional" if we want to follow the pattern
Suggested change
| return [NODE.conditionalExpr, test, consequent, alternative]; | |
| return [NODE.conditional, test, consequent, alternative]; |
Collaborator
There was a problem hiding this comment.
But it is called ConditionalExpression in the AST we receive.
Contributor
Author
There was a problem hiding this comment.
Many expressions have the Expr suffix, why should we skip this one?
cieplypolar
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
undefinedin TGSL (previously parsed tovoid0, now parses to empty string),