Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (343 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
This PR introduces two new base types, vecBase and matBase, to provide a more ergonomic way to write generic functions that work with any vector or matrix type using overloaded operators. These base types allow for more relaxed type checking compared to explicit union types like v2f | v3f | v4f.
Changes:
- Added
vecBaseinterface as a base type for all vector types - Added
matBaseinterface as a base type for all matrix types - Updated type constraints in
vecInfixNotationandmatInfixNotationto use the new base types - Modified helper types
vBaseForMatandmBaseForVecto work with the new base types - Exported the new types through the public API
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/typegpu/src/data/wgslTypes.ts | Added vecBase and matBase interfaces with documentation; updated type constraints for infix notation interfaces and helper types |
| packages/typegpu/src/data/index.ts | Exported new vecBase and matBase types to the public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iwoplaza
force-pushed
the
feat/vec-base-mat-base
branch
from
a532e67 to
391db07
Compare
iwoplaza
force-pushed
the
feat/vec-base-mat-base
branch
from
391db07 to
61b0985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.