Merged
Conversation
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (348 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Updates Vitest setup to disable @ark/attest type-checking by default (to avoid IDE Vitest stalls), while keeping an explicit opt-in for running attest-enabled test runs.
Changes:
- Add
ENABLE_ATTESTenv-gated logic inpackages/typegpuVitest global setup to control@ark/attest’sskipTypes. - Update root test scripts so attest type-checking runs only when explicitly enabled (
test:unit-and-attest), while regulartest:unitruns without it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/typegpu/setupVitest.ts | Adds env parsing and wires skipTypes to opt-in attest runs via ENABLE_ATTEST. |
| package.json | Adjusts test:* scripts to use ENABLE_ATTEST=1 for attest-enabled runs and default to skipping attest type checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cieplypolar
approved these changes
Mar 26, 2026
Collaborator
cieplypolar
left a comment
cieplypolar
left a comment
There was a problem hiding this comment.
Now, I can run tests from IDE without waiting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to this change, running Vitest tests through the IDE will no longer cause stalls.