bump: @typegpu/sdf & @typegpu/radiance-cascades#2416
Merged
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (350 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Bumps package versions in the monorepo and promotes @typegpu/radiance-cascades from an alpha/private package to a stable, publishable release.
Changes:
- Bump
@typegpu/sdffrom0.11.0→0.11.1. - Bump
@typegpu/radiance-cascadesfrom0.11.0-alpha.1→0.11.0and removeprivate: true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/typegpu-sdf/package.json | Patch version bump for @typegpu/sdf. |
| packages/typegpu-radiance-cascades/package.json | Make @typegpu/radiance-cascades publishable and set stable version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
4
| { | ||
| "name": "@typegpu/radiance-cascades", | ||
| "version": "0.11.0-alpha.1", | ||
| "private": true, | ||
| "version": "0.11.0", | ||
| "description": "Radiance Cascades implementation in TypeGPU", |
There was a problem hiding this comment.
@typegpu/radiance-cascades is no longer marked private, but its publishConfig is missing access: "public" (present in other publishable @typegpu/* packages). For scoped packages this commonly causes npm publish to default to restricted access and fail. Add publishConfig.access: "public" (or revert private: true if it’s not meant to be published).
| "version": "0.11.0", | ||
| "description": "Radiance Cascades implementation in TypeGPU", | ||
| "keywords": [], | ||
| "license": "MIT", |
There was a problem hiding this comment.
Now that @typegpu/radiance-cascades is intended to be publishable (no private: true), it should include the standard repository metadata block used by other @typegpu/* packages so consumers can trace sources/issues. Add the repository field (and optional bugs/homepage if that’s the project convention).
Suggested change
| "license": "MIT", | |
| "license": "MIT", | |
| "repository": { | |
| "type": "git", | |
| "url": "https://github.com/software-mansion/TypeGPU.git", | |
| "directory": "packages/typegpu-radiance-cascades" | |
| }, |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.97, 1.94, 4.04, 6.08, 7.38, 9.59, 22.02, 23.37]
line [0.89, 1.73, 3.91, 6.69, 7.74, 10.65, 21.86, 25.44]
line [0.87, 1.90, 3.88, 6.21, 7.18, 12.06, 22.20, 23.81]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.28, 0.52, 0.73, 0.90, 1.32, 1.20, 1.43, 1.66]
line [0.31, 0.52, 0.71, 0.91, 1.34, 1.26, 1.50, 1.64]
line [0.29, 0.53, 0.66, 0.81, 1.17, 1.22, 1.30, 1.51]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.75, 1.78, 3.73, 6.19, 12.93, 25.08, 54.81, 109.48]
line [0.81, 1.99, 3.77, 6.14, 12.10, 24.87, 57.47, 111.37]
line [0.79, 2.04, 3.29, 6.12, 12.08, 24.22, 54.00, 110.13]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.