You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit was created on GitHub.com and signed with GitHub’s verified signature.
fix(flutter): Android namespace fix for the 0.1.1 release (#218)
* fix(flutter): give the Android plugin its own namespace
The plugin declared `namespace = "com.swmansion.pulsar"`, the same
namespace as the `com.swmansion:pulsar` artifact it depends on. AGP
rejects that:
Namespace 'com.swmansion.pulsar' is used in multiple modules and/or
libraries: :pulsar_haptics, com.swmansion:pulsar:1.3.0.
Older AGP only warned, so the collision went unnoticed; newer ones (as
shipped with recent Flutter stable) make it an error and `flutter build
apk` fails outright.
Move the plugin to `com.swmansion.pulsar.flutter` — namespace, Kotlin
package, and the pubspec `package:` entry together — so it lines up with
the other bindings, which already keep the two in sync
(`com.swmansion.pulsar.reactnative`, `com.swmansion.pulsar.kmp`). The
namespace is what AGP validates; the source package moves with it so the
plugin no longer shares a package with the SDK it depends on.
The borrowed Android/Pulsar sources import
`com.swmansion.pulsar.BuildConfig`, which AGP now generates at the
.flutter package, so USE_LOCAL_PULSAR_ANDROID=1 builds need a shim for
it. It forwards to the module's real BuildConfig so DEBUG keeps tracking
the build type. Same approach as react-native-pulsar.
Also drop the deprecated `package` attribute from the plugin manifest,
ignored since AGP 8 and stale once the namespace moves.
Fixes #216
* chore(flutter): release 0.1.1
Bump the Flutter package to 0.1.1 via sdk-versions.json and the sync
script, and add the changelog entry for the Android namespace fix.
Also carries over the 0.1.0 changelog entry, which landed on main after
the pulsar_haptics-flutter-0.1.0 tag was cut and so is missing from this
release line — without it pub.dev would show 0.1.1 following 0.0.3.