ci: make npm publish dist-tag an explicit choice - #1348
Merged
Conversation
The `latest-build` boolean had only two outcomes: true published under `latest`, and *anything else* fell through to nightly - both the `executorch-nightly` dist-tag and a rewritten `x.y.z-nightly-<sha>-<date>` version. There was no way to dispatch a `legacy` publish for a maintenance release, and picking "not latest" silently produced a nightly instead. Replace it with a `release-type` choice (nightly / latest / legacy) that maps to the dist-tag directly. Only `nightly` rewrites the version. The scheduled run passes no inputs, so RELEASE_TYPE defaults to nightly.
12 tasks
A single `legacy` dist-tag only points at one version, so once 0.9 takes it over, a later 0.8 patch published as `legacy` would demote 0.9 back down. Add an optional free-text `dist-tag` input for line-scoped tags like `v0.8`, so each maintenance line keeps a stable install target and nothing has to share `legacy`. Publishing under a throwaway tag and removing it afterwards is not an option here: npm's OIDC trusted publishing authorizes `npm publish` only, so a follow-up `npm dist-tag rm` has no credentials and the junk tag would stick around. The override moves the dist-tag only - the version still comes from release-type - so combining it with nightly is rejected, as is anything npm would refuse as a dist-tag.
12 tasks
barhanc
approved these changes
Aug 4, 2026
msluszniak
added a commit
that referenced
this pull request
Aug 4, 2026
## Description Previously publish without `latest` checked published as nightly. But sometimes we want to publish new legacy version. This PR adds this possibility. ### Introduces a breaking change? - [ ] Yes - [x] No ### Type of change - [x] Bug fix (change which fixes an issue) - [ ] New feature (change which adds functionality) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] Other (chores, tests, code style improvements etc.) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions Actions → NPM publish → Run workflow → ref `release/0.9`. The form now shows a `release-type` dropdown with `nightly` / `latest` / `legacy` instead of a checkbox. ### Screenshots ### Related issues ### Checklist - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings ### Additional notes Backport of #1348, staged so 0.9 is ready when 0.10 takes over `latest`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously publish without
latestchecked published as nightly. But sometimes we want to publish new legacy version. This PR adds this possibility.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Actions → NPM publish → Run workflow. The form now shows a
release-typedropdown withnightly/latest/legacyinstead of a checkbox.Screenshots
Related issues
Checklist
Additional notes
Same change is backported to
release/0.8in a companion PR so0.8.5can be published underlegacy.