Migrate docs to FullNodeClient #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1092 +/- ##
============================================
Coverage 97.90% 97.90%
============================================
Files 86 86
Lines 3825 3825
============================================
Hits 3745 3745
Misses 80 80 ☔ View full report in Codecov by Sentry. |
drknzz
reviewed
Jun 28, 2023
Contributor
drknzz
left a comment
drknzz
left a comment
There was a problem hiding this comment.
👍
One more place I found in docs that could use some rewording:
https://starknetpy--1092.org.readthedocs.build/en/1092/guide/account_and_client.html#fullnodeclient-usage
drknzz
reviewed
Jun 29, 2023
drknzz
approved these changes
Jun 29, 2023
drknzz
reviewed
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1089
Introduced changes