MPT-18930 Add helpdesk channel API services and test coverage

[jentyk]

Summary

• Add Helpdesk.channels and AsyncHelpdesk.channels service accessors
• Implement channel resource services for /public/v1/helpdesk/channels with create/get/update/delete/list support
• Implement channel messages services for /public/v1/helpdesk/channels/{channel_id}/messages with collection-only access
• Add unit tests for new channel services and update helpdesk property tests
• Add e2e test scaffolding for channels and channel messages, with most stateful scenarios skipped for now

Testing

• uv run pytest tests/unit/resources/helpdesk/test_helpdesk.py tests/unit/resources/helpdesk/test_channels.py tests/unit/resources/helpdesk/test_channel_messages.py
• make check-all
• E2E execution: Not run (not requested)

Closes MPT-18930

Release Notes

• Added Helpdesk.channels and AsyncHelpdesk.channels service accessors to provide access to channel management functionality
• Implemented channel resource services for /public/v1/helpdesk/channels with full CRUD operations (create, get, update, delete) and list/iteration support
• Implemented channel messages collection services for /public/v1/helpdesk/channels/{channel_id}/messages with read-only access (fetch_page, iterate)
• Added both synchronous and asynchronous variants of all channel service implementations
• Added Channel model class for channel resource representation
• Added comprehensive unit tests covering synchronous and asynchronous channel services, channel messages services, and helpdesk integration
• Added E2E test scaffolding for channels and channel messages with both sync and async variants; most stateful E2E tests are currently skipped pending completion of MPT-19124
• All tests pass with make check-all

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 2256991a-427a-4d5c-a9f5-f9028eac7b7e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

🧹 Nitpick comments (1)

tests/e2e/helpdesk/channels/test_async_channels.py (1)

51-55: Consider adding match parameter for consistency with sync tests.

The sync counterpart in test_sync_channels.py uses pytest.raises(MPTAPIError) without a match, but test_sync_messages.py uses match=r"404 Not Found". Consider aligning error assertion patterns across all E2E tests for consistency—either all use match or none do.

♻️ Optional: Add match parameter for more specific error validation

 async def test_not_found(async_mpt_ops, invalid_channel_id):
     service = async_mpt_ops.helpdesk.channels
 
-    with pytest.raises(MPTAPIError):
+    with pytest.raises(MPTAPIError, match=r"404"):
         await service.get(invalid_channel_id)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/e2e/helpdesk/channels/test_async_channels.py` around lines 51 - 55,
Update the async test_not_found to assert the specific 404 error string like the
other message tests: when calling service.get(invalid_channel_id) inside
pytest.raises(MPTAPIError) add match=r"404 Not Found" so the test uses a precise
error-match (refer to test_not_found, service.get, and pytest.raises).

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tests/e2e/helpdesk/channels/test_async_channels.py`:
- Around line 51-55: Update the async test_not_found to assert the specific 404
error string like the other message tests: when calling
service.get(invalid_channel_id) inside pytest.raises(MPTAPIError) add
match=r"404 Not Found" so the test uses a precise error-match (refer to
test_not_found, service.get, and pytest.raises).

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ba54a0a8-41df-43ba-93f8-5553716fd89d

📥 Commits

Reviewing files that changed from the base of the PR and between 676f1c1 and ca33fd5.

📒 Files selected for processing (12)

• mpt_api_client/resources/helpdesk/channel_messages.py
• mpt_api_client/resources/helpdesk/channels.py
• mpt_api_client/resources/helpdesk/helpdesk.py
• tests/e2e/helpdesk/channels/conftest.py
• tests/e2e/helpdesk/channels/messages/conftest.py
• tests/e2e/helpdesk/channels/messages/test_async_messages.py
• tests/e2e/helpdesk/channels/messages/test_sync_messages.py
• tests/e2e/helpdesk/channels/test_async_channels.py
• tests/e2e/helpdesk/channels/test_sync_channels.py
• tests/unit/resources/helpdesk/test_channel_messages.py
• tests/unit/resources/helpdesk/test_channels.py
• tests/unit/resources/helpdesk/test_helpdesk.py