Skip to content

MPT-19479 E2E: Helpdesk Chats core#249

Merged
jentyk merged 3 commits intomainfrom
feat/MPT-19479
Mar 25, 2026
Merged

MPT-19479 E2E: Helpdesk Chats core#249
jentyk merged 3 commits intomainfrom
feat/MPT-19479

Conversation

@jentyk
Copy link
Member

@jentyk jentyk commented Mar 25, 2026

Closes MPT-19479

  • Added test package structure for Helpdesk channels, messages, parameter groups, and queues with __init__.py files
  • Enabled core Helpdesk chat e2e tests by removing skip decorators from test_get_chat, test_list_chats, and test_update_chat in both sync and async test suites
  • Added skip decorators to channel message "not found" tests pending completion of MPT-19124

@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 14db56ae-93bd-423d-a35d-0fc44661e554

📥 Commits

Reviewing files that changed from the base of the PR and between 3d19416 and a732c0d.

📒 Files selected for processing (9)
  • tests/e2e/helpdesk/channels/__init__.py
  • tests/e2e/helpdesk/channels/messages/__init__.py
  • tests/e2e/helpdesk/channels/messages/test_async_messages.py
  • tests/e2e/helpdesk/channels/messages/test_sync_messages.py
  • tests/e2e/helpdesk/chats/test_async_chats.py
  • tests/e2e/helpdesk/chats/test_sync_chats.py
  • tests/e2e/helpdesk/parameter_groups/__init__.py
  • tests/e2e/helpdesk/parameter_groups/parameters/__init__.py
  • tests/e2e/helpdesk/queues/__init__.py
💤 Files with no reviewable changes (2)
  • tests/e2e/helpdesk/chats/test_async_chats.py
  • tests/e2e/helpdesk/chats/test_sync_chats.py

📝 Walkthrough

Walkthrough

This PR establishes test package hierarchies for helpdesk channels, parameter groups, and queues by adding empty __init__.py files, while selectively re-enabling three previously skipped chat tests and marking specific channel message tests as skipped pending MPT-19124 completion.

Changes

Cohort / File(s) Summary
Test Package Initialization
tests/e2e/helpdesk/channels/__init__.py, tests/e2e/helpdesk/channels/messages/__init__.py, tests/e2e/helpdesk/parameter_groups/__init__.py, tests/e2e/helpdesk/parameter_groups/parameters/__init__.py, tests/e2e/helpdesk/queues/__init__.py
Added empty __init__.py files to establish Python package structure for new test module hierarchies.
Channel Message Test Skip Markers
tests/e2e/helpdesk/channels/messages/test_async_messages.py, tests/e2e/helpdesk/channels/messages/test_sync_messages.py
Added @pytest.mark.skip decorator to test_list_channel_messages_not_found tests with reason "Unskip after MPT-19124 completed".
Chat Test Unskip Markers
tests/e2e/helpdesk/chats/test_async_chats.py, tests/e2e/helpdesk/chats/test_sync_chats.py
Removed @pytest.mark.skip decorators from test_get_chat, test_list_chats, and test_update_chat, enabling these tests to execute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the correct format (MPT-19479) at the beginning.
Test Coverage Required ✅ Passed All modified files are within the tests/ folder. No code files outside tests/ directory have been modified.
Single Commit Required ✅ Passed The pull request contains exactly one commit (a732c0d) with message 'test(helpdesk): unskip chat e2e tests', meeting the single commit requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@jentyk jentyk marked this pull request as ready for review March 25, 2026 15:52
@jentyk jentyk requested a review from a team as a code owner March 25, 2026 15:52
@jentyk jentyk requested review from d3rky and ruben-sebrango March 25, 2026 15:52
@jentyk jentyk merged commit 59d7853 into main Mar 25, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19479 branch March 25, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants