Skip to content

MPT-19696 update skip reasons for channel and message tests #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jentyk merged 1 commit into from
Apr 7, 2026
Merged

MPT-19696 update skip reasons for channel and message tests #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tests/e2e/helpdesk/channels/messages/test_async_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@
from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.resources.helpdesk.chat_messages import ChatMessage

pytestmark = [pytest.mark.flaky]
pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")]


@pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")
async def test_list_channel_messages(async_channel_messages_service):
result = await async_channel_messages_service.fetch_page(limit=1)

assert len(result) > 0
assert all(isinstance(message, ChatMessage) for message in result)


@pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")
async def test_list_channel_messages_not_found(async_mpt_ops, invalid_channel_id):
with pytest.raises(MPTAPIError) as error:
await async_mpt_ops.helpdesk.channels.messages(invalid_channel_id).fetch_page(limit=1)
Expand Down
4 changes: 1 addition & 3 deletions tests/e2e/helpdesk/channels/messages/test_sync_messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@
from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.resources.helpdesk.chat_messages import ChatMessage

pytestmark = [pytest.mark.flaky]
pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")]


@pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")
def test_list_channel_messages(channel_messages_service):
result = channel_messages_service.fetch_page(limit=1)

assert len(result) > 0
assert all(isinstance(message, ChatMessage) for message in result)


@pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")
def test_list_channel_messages_not_found(mpt_ops, invalid_channel_id):
with pytest.raises(MPTAPIError) as error:
mpt_ops.helpdesk.channels.messages(invalid_channel_id).fetch_page(limit=1)
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/helpdesk/channels/test_async_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.resources.helpdesk.channels import Channel

pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip after MPT-19124 completed")]
pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")]


async def test_get_channel(async_mpt_ops, channel_id):
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/helpdesk/channels/test_sync_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from mpt_api_client.exceptions import MPTAPIError
from mpt_api_client.resources.helpdesk.channels import Channel

pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip after MPT-19124 completed")]
pytestmark = [pytest.mark.flaky, pytest.mark.skip(reason="Unskip when MPT-19696 unblocked")]


def test_get_channel(mpt_ops, channel_id):
Expand Down