Skip to content

MPT-19696 update skip reasons for channel and message tests#290

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19696
Apr 7, 2026
Merged

MPT-19696 update skip reasons for channel and message tests#290
jentyk merged 1 commit intomainfrom
feat/MPT-19696

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19696

  • Updated skip reasons across helpdesk channel and message test files from "Unskip after MPT-19124 completed" to "Unskip when MPT-19696 unblocked"
  • Consolidated per-test skip decorators to module-level pytestmark in async and sync message test files (test_async_messages.py, test_sync_messages.py)
  • Updated skip conditions in channel test files (test_async_channels.py, test_sync_channels.py) to reflect MPT-19696 blocking condition

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 14:19
@jentyk jentyk requested review from robcsegal and svazquezco April 7, 2026 14:19
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c6d6564a-e9ea-4f09-8375-6c5530cf5191

📥 Commits

Reviewing files that changed from the base of the PR and between 1879878 and 7491e4b.

📒 Files selected for processing (4)
  • tests/e2e/helpdesk/channels/messages/test_async_messages.py
  • tests/e2e/helpdesk/channels/messages/test_sync_messages.py
  • tests/e2e/helpdesk/channels/test_async_channels.py
  • tests/e2e/helpdesk/channels/test_sync_channels.py

📝 Walkthrough

Walkthrough

The PR consolidates and updates pytest skip markers across four E2E test files in the helpdesk channels module. For message tests, per-test skip decorators are consolidated into module-level markers. For channel tests, skip reasons are updated from MPT-19124 to MPT-19696.

Changes

Cohort / File(s) Summary
Message test skip consolidation
tests/e2e/helpdesk/channels/messages/test_async_messages.py, tests/e2e/helpdesk/channels/messages/test_sync_messages.py
Consolidated per-test @pytest.mark.skip decorators into module-level pytestmark markers. Skip scope moved from individual test functions to file-wide configuration.
Channel test skip reason update
tests/e2e/helpdesk/channels/test_async_channels.py, tests/e2e/helpdesk/channels/test_sync_channels.py
Updated module-level skip reason from "Unskip after MPT-19124 completed" to "Unskip when MPT-19696 unblocked". No changes to test logic or scope.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key MPT-19696 in the required MPT-XXXX format at the beginning.
Test Coverage Required ✅ Passed All modified files are in tests/ directory. No code files outside tests/ were modified.
Single Commit Required ✅ Passed PR contains exactly one commit (7491e4b) consolidating all changes for updating skip reasons across four test files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@jentyk jentyk merged commit 2c52628 into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19696 branch April 7, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants