-
Notifications
You must be signed in to change notification settings - Fork 8
Fix #347: Rebuild pyproject.toml to adhere to PEP 621 & update poetry version
#407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure user agent name in utils is a combination of package name, version and homepage URL: #347 (comment)
- Build failed - RTD docs provide guidance for building with poetry: https://test-builds.readthedocs.io/en/poetry/ - This change uses the guidance
led02
reviewed
Aug 1, 2025
Member
led02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remarks made, looking good so far. Thanks for the great efford!
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
led02
approved these changes
Aug 1, 2025
Member
led02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️⭐️⭐️⭐️⭐️
Great review experience, will review again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.tomlNotes
hermesis installed in the workspace the tests are run from. This is because we're comparing distribution to declared metadata, and they may differ in real-life workspaces.pyproject.tomlhermes.software-metadata.pub(@zyzzyxdonta Does this break anything in terms of the user agent?)poetry.tool-related tables frompyproject.toml, as these were superfluous:schema.jsonfile doesn't even exist anymoretomlto be present in the environment, which of course was only added to standard lib (tomllib) with 3.11.