Skip to content

Updates to cross program invocation#10

Closed
dadepo wants to merge 7 commits intosolana-developers:mainfrom
dadepo:updates-to-cross-program-invocation
Closed

Updates to cross program invocation#10
dadepo wants to merge 7 commits intosolana-developers:mainfrom
dadepo:updates-to-cross-program-invocation

Conversation

@dadepo
Copy link
Copy Markdown
Contributor

@dadepo dadepo commented Sep 12, 2022

This PR adds the following:

  • Updates the README to explain how the Cargo features is used to ensure there is only one entrypoint! when a Solana program depends on another Solana program
  • Simplifies how the Cargo feature is used

@dadepo dadepo marked this pull request as ready for review September 13, 2022 21:11
@ngundotra
Copy link
Copy Markdown
Contributor

Readme changes seem quite similar to #13, can you move your README changes to #13 only please?

Also, what do you mean by lever and hand crate? Otherwise, your additional docs look fine

@ngundotra
Copy link
Copy Markdown
Contributor

Please add a comment to this PR explaining your changes

@dadepo
Copy link
Copy Markdown
Contributor Author

dadepo commented Oct 26, 2022

Readme changes seem quite similar to #13, can you move your README changes to #13 only please?

Done

Also, what do you mean by lever and hand crate? Otherwise, your additional docs look fine

I was referring to this(lever) and this(hand). I referred to them by the rust convention of crates.

@buffalojoec
Copy link
Copy Markdown
Contributor

If you moved this over from #10 can we close #10 and merge #13?

@dadepo
Copy link
Copy Markdown
Contributor Author

dadepo commented Oct 26, 2022

If you moved this over from #10 can we close #10 and merge #13?

sure!

Moved the changes here to #13. Closing as suggested

@dadepo dadepo closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants