Skip to content

Improvements to checking accounts#9

Merged
buffalojoec merged 7 commits intosolana-developers:mainfrom
dadepo:improvements-to-checking-accounts
Oct 26, 2022
Merged

Improvements to checking accounts#9
buffalojoec merged 7 commits intosolana-developers:mainfrom
dadepo:improvements-to-checking-accounts

Conversation

@dadepo
Copy link
Copy Markdown
Contributor

@dadepo dadepo commented Sep 11, 2022

This PR

  • sets the Program ID
  • Adds a README.

The Program ID is required because if it is not set, the tests passes but shows no tests were run:



  0 passing (0ms)

✨  Done in 0.70s.

This is because the describe function, is annotated to be an async function. Removing the async keyword and running the test, the issue becomes obvious, and it fails with the following error:

ts-mocha -p ./tsconfig.json -t 1000000 ./tests/test.ts

Error: Invalid public key input
    at new PublicKey... 

@ngundotra
Copy link
Copy Markdown
Contributor

Tagging @realbuffalojoe for review

@ngundotra
Copy link
Copy Markdown
Contributor

But also, please see feedback on #10 about your README updates to create-account example

Copy link
Copy Markdown
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buffalojoec buffalojoec merged commit 6c5df49 into solana-developers:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants