Skip to content

docs(counter): fix native readme for the bankrun/pnpm flow#608

Merged
dev-jodee merged 1 commit into
mainfrom
docs/counter-native-readme
Jun 24, 2026
Merged

docs(counter): fix native readme for the bankrun/pnpm flow#608
dev-jodee merged 1 commit into
mainfrom
docs/counter-native-readme

Conversation

@dev-jodee

Copy link
Copy Markdown
Collaborator

Summary

  • basics/counter/native/README.md still documented the old, removed workflow (yarn test, yarn start-validator, yarn run-tests + a local solana-test-validator). Those scripts no longer exist.
  • The example now builds with cargo build-sbf and tests in-process via solana-bankrun (no validator). Update the README to the current pnpm build-and-test / pnpm build / pnpm deploy scripts.

Test Plan

  • Docs-only change; no code affected.
  • Verified the documented commands match basics/counter/native/package.json scripts, and that counter/native builds + tests green in CI (bankrun, loads from ./tests/fixtures).

The underlying bug in the issue (the ./target/deploy/counter_solana_native.so not-found error from the old yarn/validator setup) was already resolved by the rewrite to solana-bankrun; this finishes it by fixing the stale docs.

Closes #67

The README still documented the removed yarn + solana-test-validator setup
(yarn start-validator / yarn run-tests). counter/native now builds with
cargo build-sbf and tests in-process via solana-bankrun, so document the
current pnpm build-and-test / build / deploy scripts instead.
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates basics/counter/native/README.md to replace the obsolete yarn-based workflow (which referenced scripts that no longer exist) with the current pnpm-based commands that match the live package.json.

  • Removes stale yarn test / yarn start-validator / yarn run-tests + local validator instructions and replaces them with pnpm build-and-test, pnpm build, and pnpm deploy.
  • The documented commands were verified against package.json — all three scripts exist and behave as described (bankrun in-process, no validator needed).

Confidence Score: 5/5

Documentation-only change; no code paths are touched and the documented commands exactly match the live package.json scripts.

All three commands introduced in the README (pnpm build-and-test, pnpm build, pnpm deploy) exist verbatim in package.json and the description of bankrun in-process testing accurately reflects what the scripts do. The old yarn scripts being replaced no longer exist in the project.

No files require special attention.

Important Files Changed

Filename Overview
basics/counter/native/README.md Docs-only update replacing removed yarn scripts with correct pnpm equivalents; all three commands verified against package.json.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Developer] -->|pnpm build-and-test| B[cargo build-sbf]
    B --> C[./tests/fixtures/*.so]
    C --> D[pnpm test / ts-mocha]
    D --> E[solana-bankrun in-process]
    E --> F[Tests pass ✓]

    A -->|pnpm build| G[cargo build-sbf]
    G --> H[./program/target/so/program.so]
    H -->|pnpm deploy| I[solana program deploy]
    I --> J[On-chain deployment]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Developer] -->|pnpm build-and-test| B[cargo build-sbf]
    B --> C[./tests/fixtures/*.so]
    C --> D[pnpm test / ts-mocha]
    D --> E[solana-bankrun in-process]
    E --> F[Tests pass ✓]

    A -->|pnpm build| G[cargo build-sbf]
    G --> H[./program/target/so/program.so]
    H -->|pnpm deploy| I[solana program deploy]
    I --> J[On-chain deployment]
Loading

Reviews (1): Last reviewed commit: "docs(counter): fix native readme for the..." | Re-trigger Greptile

@dev-jodee dev-jodee merged commit 606d5ab into main Jun 24, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: program file does not exist: ./target/deploy/counter_solana_native.so

2 participants