fix: correct parameter count in token-swap README - #663
Merged
dev-jodee merged 1 commit intoAug 3, 2026
Merged
Conversation
swap_exact_tokens_for_tokens takes 4 parameters (ctx, swap_a, input_amount, min_output_amount), not 5 as the doc stated.
Contributor
Greptile SummaryCorrects the token-swap walkthrough to state that Confidence Score: 5/5The PR appears safe to merge because the documentation correction is internally consistent and introduces no runtime changes. The revised count matches the four parameters enumerated in the walkthrough, and the change affects only explanatory documentation. Important Files Changed
Reviews (1): Last reviewed commit: "fix(#494): correct parameter count in to..." | Re-trigger Greptile |
dev-jodee
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #494 — the walkthrough for
swap_exact_tokens_for_tokenssaid it "takes five parameters" but only ever listed and described four:ctx,swap_a,input_amount,min_output_amount. The actual function signature (tokens/token-swap/anchor/programs/token-swap/src/instructions/swap_exact_tokens_for_tokens.rs) confirms it's 4 params, not 5.Test plan