Skip to content

SPL Token fundraiser program example - #82

Merged
jacobcreech merged 31 commits into
solana-foundation:mainfrom
ASCorreia:main
Jun 26, 2024
Merged

SPL Token fundraiser program example#82
jacobcreech merged 31 commits into
solana-foundation:mainfrom
ASCorreia:main

Conversation

@ASCorreia

Copy link
Copy Markdown
Contributor

SPL Token Program with anchor 0.30 and Solana Program 1.18

@ASCorreia

Copy link
Copy Markdown
Contributor Author

@Woody4618 Could you have a look when you have the time?

@Woody4618 Woody4618 assigned Woody4618 and unassigned Woody4618 Jun 18, 2024
@Woody4618
Woody4618 self-requested a review June 18, 2024 14:45

@Woody4618 Woody4618 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, thank you for writing this \o/

I added some questions. Would be nice if you could address. Them in general its great.

I also ran the tests. All green :)

Comment thread tokens/token-fundraiser/anchor/programs/fundraiser/src/instructions/initialize.rs Outdated
Comment thread tokens/token-fundraiser/anchor/programs/fundraiser/src/instructions/refund.rs Outdated
Comment thread tokens/token-fundraiser/anchor/tests/fundraiser.ts Outdated
const tx = await program
.methods
.initialize(new anchor.BN(30000000), 0)
.accountsPartial({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you are using accountsPartial here instead of accounts? With anchor 30 you can save a bunch of these accounts probably.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal, since it is an example, is just to show all the accounts needed being passed

Comment thread tokens/token-fundraiser/anchor/tests/fundraiser.ts Outdated
Comment thread tokens/token-fundraiser/anchor/readme.MD
Comment thread tokens/token-fundraiser/anchor/readme.MD Outdated
Comment thread tokens/token-fundraiser/anchor/readme.MD Outdated
Comment thread tokens/token-fundraiser/anchor/readme.MD Outdated
Comment thread tokens/token-fundraiser/anchor/readme.MD Outdated
@ASCorreia
ASCorreia requested a review from Woody4618 June 18, 2024 17:45
@Woody4618

Copy link
Copy Markdown
Collaborator

Thank you for the changes. Could you please pull in master and run the biome checks. You can find them in the package.json.
running
pnpm lint:fix
and
pnpm format:fix

will probably do the trick.

@ASCorreia

Copy link
Copy Markdown
Contributor Author

Should be ok now

@heyAyushh

Copy link
Copy Markdown
Contributor

@ASCorreia What's the required anchor and solana version?
I guess for anchor it's 0.30.1?

@ASCorreia

Copy link
Copy Markdown
Contributor Author

@heyAyushh It was initially Anchor 0.30.0 and Solana 1.18.12, and yesterday I migrated it to Anchor 0.30.1 and Solana 1.18.8 after seeing the issues in the job work

@ASCorreia

Copy link
Copy Markdown
Contributor Author

Added NFT operations program example

@jacobcreech
jacobcreech merged commit 82e5f16 into solana-foundation:main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants