implement config options - #5
Merged
Merged
Conversation
samkim-crypto
left a comment
samkim-crypto
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Let me know what you think about my comments below.
samkim-crypto
approved these changes
Jul 23, 2026
samkim-crypto
left a comment
samkim-crypto
left a comment
Contributor
There was a problem hiding this comment.
Okay looks good to me!
I think some parts, especially the docs can be simplified and smoothed out a bit, but that can be done in follow-up PRs. Let's also address Jon's comments in #2 in follow-up PRs as well.
joncinque
reviewed
Jul 23, 2026
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just some flyby comments
Comment on lines
+107
to
+111
| impl Default for VerificationCriteria { | ||
| fn default() -> Self { | ||
| Self::zip215() | ||
| } | ||
| } |
There was a problem hiding this comment.
Default seems like a footgun for this type -- can we remove it?
Comment on lines
+19
to
+20
| dalek | ||
| dalek's |
There was a problem hiding this comment.
nit: you should be able to combine these by doing dalek/P
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed #3, this PR adds a configuration byte
variantto allow for invocation of different verification methods.currently only zip-215 and dalek variants are supported.