Conversation
grod220
commented
Mar 31, 2026
Comment on lines
+178
to
+180
| where | ||
| L: PodLength, | ||
| PodSliceError: From<<L as TryFrom<usize>>::Error>, |
Member
Author
There was a problem hiding this comment.
init needs the where to preserve the old length-conversion behavior
grod220
commented
Mar 31, 2026
Comment on lines
+57
to
+59
| where | ||
| <L as TryFrom<usize>>::Error: std::fmt::Debug, | ||
| { |
Member
Author
There was a problem hiding this comment.
Test helper has to spell out Debug now because unwrap() can no longer assume the conversion error is the old concrete type
grod220
commented
Mar 31, 2026
Comment on lines
+23
to
+26
| spl-discriminator = { version = "0.5.1", path = "../discriminator" } | ||
| spl-list-view = { version = "0.1.0", path = "../list-view" } | ||
| spl-pod = { version = "0.7.2", path = "../pod" } | ||
| spl-type-length-value = { version = "0.9.0", path = "../type-length-value" } |
joncinque
approved these changes
Apr 1, 2026
Comment on lines
+12
to
+13
| // Re-export the conversion macro (replaces the old #[macro_export] definition) | ||
| pub use solana_zero_copy::impl_int_conversion; |
Contributor
There was a problem hiding this comment.
why did we export that macro 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the creation of
solana-zero-copy,spl-podis effectively deprecated. This PR is attempting to ease the transition for consumers by aliasing the primitives to the new zero copy types.Patch release to proceed this PR.