program: Move slippage check down during withdraw-stake - #883
Open
joncinque wants to merge 1 commit into
Open
Conversation
#### Problem The stake pool program allows users to withdraw whole stake accounts in certain situations. In those cases, the amount of lamports withdrawn gets truncated downt to the current amount of lamports in the account. The program also allows users to specify slippage when withdrawing from the pool. The withdraw-stake instruction runs the slippage check before the withdrawal amount has been rounded down when withdrawing a stake account, potentially violating the slippage param set by the user. #### Summary of changes Move the slippage check down to after the withdraw amount has been changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stake pool program allows users to withdraw whole stake accounts in certain situations. In those cases, the amount of lamports withdrawn gets truncated downt to the current amount of lamports in the account.
The program also allows users to specify slippage when withdrawing from the pool. The withdraw-stake instruction runs the slippage check before the withdrawal amount has been rounded down when withdrawing a stake account, potentially violating the slippage param set by the user.
Summary of changes
Move the slippage check down to after the withdraw amount has been changed.
Fixes #882