Clean up the repo - #12
Merged
Merged
Conversation
Repository owner
requested a review
from d87f71d598f4db10bfa0f4b71d0afbe3171_swi
September 3, 2021 18:42
| @@ -1 +1,17 @@ | |||
| # explicitly list all the build directories instead of an asterisk (**/build/) to avoid possible unwanted match | |||
| /instrumentation/build/ | |||
Mannequin
There was a problem hiding this comment.
2 suggestions:
are you excluding all build directories?
**/build
I like to put ignores not related to the code but your personal setup like this
$ git config --global core.excludesfile ~/.gitignore
$ echo '.idea' >> ~/.gitignore
Author
There was a problem hiding this comment.
It's a good idea! and yes I also don't want to reveal which IDE I'm using :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some clean-ups so it doesn't belong to any jira ticket.