Conversation
* fix: 인증 완료 학교 이메일 저장 구조를 추가 * fix: 학교 이메일 중복 인증을 차단 * test: 학교 이메일 중복 인증 차단을 검증 * fix: 소비된 조회수 Redis 키를 무시한다 * fix: 학교 이메일 요청 길이 검증을 추가한다
수동 트리거로 PostViewCountConcurrencyTest를 50회 반복 실행해 플레이키니스를 검증할 수 있도록 한다. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* feat: AdminRefreshToken 클래스 작성 및 관련 설정 추가
* feat: cookie manager 추가
* feat: 어드민 refresh token 관련 error code 작성
* feat: provider에 관련 메서드 추가
- redis에 ADMIN_REFRESH:{userId} 형태로 토큰 저장
* feat: 어드민 로그인 관련 비즈니즈 로직, DTO 작성
- 관련 테스트 구현
* feat: 어드민 로그인 관련 컨트롤러 구현
* feat: 어드민 로그인 관련은 인증 없이 접근 가능하도록 스프링 시큐리티 설정 변경
* refactor: 쿠키 SameSite 속성을 LAX -> Strict으로 변경
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b51872a327
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ALTER TABLE application | ||
| DROP COLUMN first_choice_university_info_for_apply_id, | ||
| DROP COLUMN second_choice_university_info_for_apply_id, | ||
| DROP COLUMN third_choice_university_info_for_apply_id; |
There was a problem hiding this comment.
For databases that contain applications created before application_choice was introduced, these columns are still the only persisted copy of each application's first/second/third university choices. I checked the migrations that reference application_choice/first_choice_university_info_for_apply_id, and there is no INSERT ... SELECT (or equivalent) that copies the legacy column values into application_choice before this drop, so applying V56 permanently deletes those choices and makes applicants disappear from choice-based queries/results. Add a backfill migration before dropping these columns, or keep the columns until the data has been copied and verified.
Useful? React with 👍 / 👎.
3 participants
No description provided.