Skip to content

feat: 어드민 인증 필요 시 알림을 보내도록 #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whqtker merged 6 commits into from
Aug 5, 2026
Merged

feat: 어드민 인증 필요 시 알림을 보내도록 #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c7c304f
feat: Discord 검수 알림 전송을 위한 DiscordNotifier 추가
whqtker Aug 5, 2026
cfb0b50
feat: 학점/어학 성적 등록 완료 시 Discord 검수 알림 전송
whqtker Aug 5, 2026
711fee1
feat: 멘토 신청 등록 완료 시 Discord 검수 알림 전송
whqtker Aug 5, 2026
bd5ef55
feat: 신고 등록 완료 시 Discord 검수 알림 전송
whqtker Aug 5, 2026
282496c
fix: 환경 미지정 시 기본값을 local 대신 빈 문자열로 변경
whqtker Aug 5, 2026
8729a79
refactor: notifyReviewRequested를 notify로 이름 변경
whqtker Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main/java/com/example/solidconnection/common/discord/DiscordNotificationType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.example.solidconnection.common.discord;

import lombok.Getter;

@Getter
public enum DiscordNotificationType {

GPA_SCORE("학점 성적"),
LANGUAGE_TEST_SCORE("어학 성적"),
MENTOR_APPLICATION("멘토 신청"),
REPORT("신고"),
;

private final String displayName;

DiscordNotificationType(String displayName) {
this.displayName = displayName;
}
}
50 changes: 50 additions & 0 deletions src/main/java/com/example/solidconnection/common/discord/DiscordNotifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package com.example.solidconnection.common.discord;

import java.util.Map;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.http.HttpEntity;
import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType;
import org.springframework.scheduling.annotation.Async;
import org.springframework.scheduling.annotation.EnableAsync;
import org.springframework.stereotype.Component;
import org.springframework.web.client.RestTemplate;

@Component
@RequiredArgsConstructor
@EnableAsync
@Slf4j
public class DiscordNotifier {

private static final String ADMIN_PAGE_URL = "https://admins.solid-connection.com";

private final RestTemplate restTemplate;

@Value("${discord.webhook-url:}")
private String webhookUrl;

@Value("${spring.profiles.active:}")
private String environment;
Comment on lines +28 to +29

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

환경 값이 비어 있으면 접두사를 생략하세요.

spring.profiles.active의 기본값이 빈 문자열이므로 환경이 지정되지 않으면 메시지가 [] 학점 성적 검수 요청... 형식으로 시작합니다. 빈 환경을 유지하려면 환경 접두사 전체를 생략하세요.

Also applies to: 46-48

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/example/solidconnection/common/discord/DiscordNotifier.java`
around lines 28 - 29, Update DiscordNotifier’s message construction to omit the
environment prefix, including its brackets and spacing, when the injected
environment value is blank; retain the existing prefixed format when an
environment is configured.


@Async

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Discord task rejection from aborting requests

When the shared async executor is full (it is bounded in AsyncConfig and also used by S3/view-count work), calling an @Async method can be rejected before notify() enters its try/catch. In that case the transactional score, mentor, or report request can fail or roll back solely because the Discord notification could not be queued; wrap the proxy call/rejection or use a dedicated best-effort executor/rejection policy.

Useful? React with 👍 / 👎.

public void notify(DiscordNotificationType type, String applicantInfo) {
if (webhookUrl.isBlank()) {
return;
}
try {
HttpHeaders headers = new HttpHeaders();
headers.setContentType(MediaType.APPLICATION_JSON);
HttpEntity<Map<String, String>> request = new HttpEntity<>(Map.of("content", buildMessage(type, applicantInfo)), headers);

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Disable mentions for user-provided Discord content

When this notifier is called from score and mentor submissions, applicantInfo is siteUser.getNickname(), which users can control. Because the webhook payload only sends raw content, a nickname such as @everyone, @here, or a role mention will be parsed by Discord and can ping the admin channel whenever that user submits a score or mentor application; add allowed_mentions with an empty parse list or escape user-supplied text before sending.

Useful? React with 👍 / 👎.

restTemplate.postForEntity(webhookUrl, request, Void.class);
} catch (Exception e) {
log.error("Discord 검수 알림 전송 실패. type={}, applicantInfo={}", type, applicantInfo, e);
}
Comment on lines +41 to +43

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Files matching DiscordNotifier:"
fd -i 'DiscordNotifier' . || true

echo
echo "Git status/stat:"
git diff --stat || true

echo
echo "DiscordNotifier outline:"
file="$(fd -i '^DiscordNotifier\.java$' . | head -n1 || true)"
if [ -n "${file:-}" ]; then
  echo "FILE=$file"
  wc -l "$file"
  ast-grep outline "$file" || true
  echo
  echo "DiscordNotifier relevant lines:"
  cat -n "$file" | sed -n '1,180p'
fi

echo
echo "Search Discord notifier usages and related outbox/queue terms:"
rg -n "DiscordNotifier|sendExam|exam|outbox|queue|retries?|retry|DeadLetter|DLQ|실패|실패한|성공" src/main/java src/test/java 2>/dev/null || true

Repository: solid-connection/solid-connect-server

Length of output: 50394

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Project configuration files:"
git ls-files | rg '(^|/)(build\.gradle|build\.gradle\.kts|pom\.xml|gradle\.properties|settings\.gradle|docker-compose\.ya?ml|application.*\.ya?ml|application.*\.properties)$' || true

echo
echo "Search notification infrastructure:"
rg -n "AsyncEventListener|ApplicationEvent.|`@Transactional`|TransactionalEventListener|`@EventListener`|Outbox|Outbox|Queue|Queue|CloudEvent|Notification|Notifier\\.|sendExam|sendExam" src/main/java 2>/dev/null || true

Repository: solid-connection/solid-connect-server

Length of output: 17180

1. 실패한 Discord 알림을 저장하고 재시도하세요.

DiscordNotifier.notify(...)가 내부 예외를 로그에만 남기기 때문에 Discord 429, 5xx, 네트워크 오류는 알림 유실로 이어집니다. 이벤트 또는 전송 상태를 outbox/queue에 저장하고, 중복 전송 방지와 함께 제한된 재시도, 실패 보관/경보를 구현하세요.

  • 1 전송 실패 시 이벤트 또는 전송 기록을 outbox/queue에 저장하세요.
  • 2 중복 전송 방지와 제한된 재시도를 함께 구현하세요.
  • 3 재시도 모두 실패 시 실패 보관/알림 경로로 이동시키세요.
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/example/solidconnection/common/discord/DiscordNotifier.java`
around lines 41 - 43, Update DiscordNotifier.notify(...) so the catch path no
longer only logs and drops failures; instead persist the failed alert or send
event to the existing outbox/queue flow, using DiscordNotifier as the entry
point and the current type/applicantInfo payload as the retry record. Add
deduplication and a bounded retry policy around the send operation, and route
exhausted retries to the failure-storage/alert path rather than swallowing the
exception.

}

private String buildMessage(DiscordNotificationType type, String applicantInfo) {
return "[%s] %s 검수 요청이 등록되었습니다.\n신청자: %s\n관리자 페이지: %s"
.formatted(environment.toUpperCase(), type.getDisplayName(), applicantInfo, ADMIN_PAGE_URL);
}
}
4 changes: 4 additions & 0 deletions src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import static com.example.solidconnection.common.exception.ErrorCode.TERM_NOT_FOUND;
import static com.example.solidconnection.common.exception.ErrorCode.USER_NOT_FOUND;

import com.example.solidconnection.common.discord.DiscordNotificationType;
import com.example.solidconnection.common.discord.DiscordNotifier;
import com.example.solidconnection.common.exception.CustomException;
import com.example.solidconnection.mentor.domain.MentorApplication;
import com.example.solidconnection.mentor.domain.MentorApplicationStatus;
Expand Down Expand Up @@ -35,6 +37,7 @@ public class MentorApplicationService {
private final SiteUserRepository siteUserRepository;
private final S3Service s3Service;
private final TermRepository termRepository;
private final DiscordNotifier discordNotifier;

@Transactional
public void submitMentorApplication(
Expand All @@ -60,6 +63,7 @@ public void submitMentorApplication(
mentorApplicationRequest.exchangeStatus()
);
mentorApplicationRepository.save(mentorApplication);
discordNotifier.notify(DiscordNotificationType.MENTOR_APPLICATION, siteUser.getNickname());
}

private void ensureNoPendingOrApprovedMentorApplication(long siteUserId) {
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/example/solidconnection/report/service/ReportService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import com.example.solidconnection.chat.domain.ChatParticipant;
import com.example.solidconnection.chat.repository.ChatMessageRepository;
import com.example.solidconnection.chat.repository.ChatParticipantRepository;
import com.example.solidconnection.common.discord.DiscordNotificationType;
import com.example.solidconnection.common.discord.DiscordNotifier;
import com.example.solidconnection.common.exception.CustomException;
import com.example.solidconnection.common.exception.ErrorCode;
import com.example.solidconnection.community.post.domain.Post;
Expand All @@ -28,6 +30,7 @@ public class ReportService {
private final PostRepository postRepository;
private final ChatMessageRepository chatMessageRepository;
private final ChatParticipantRepository chatParticipantRepository;
private final DiscordNotifier discordNotifier;

@Transactional
public void createReport(long reporterId, ReportRequest request) {
Expand All @@ -39,6 +42,7 @@ public void createReport(long reporterId, ReportRequest request) {

Report report = new Report(reporterId, reportedId, request.reportType(), request.targetType(), request.targetId());
reportRepository.save(report);
discordNotifier.notify(DiscordNotificationType.REPORT, "신고자 ID: " + reporterId);
}

private void validateReporterAndReportedExists(long reporterId, long reportedId) {
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/com/example/solidconnection/score/service/ScoreService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import com.example.solidconnection.application.domain.Gpa;
import com.example.solidconnection.application.domain.LanguageTest;
import com.example.solidconnection.common.discord.DiscordNotificationType;
import com.example.solidconnection.common.discord.DiscordNotifier;
import com.example.solidconnection.common.exception.CustomException;
import com.example.solidconnection.s3.domain.UploadPath;
import com.example.solidconnection.s3.dto.UploadedFileUrlResponse;
Expand Down Expand Up @@ -37,6 +39,7 @@ public class ScoreService {
private final LanguageTestScoreRepository languageTestScoreRepository;
private final SiteUserRepository siteUserRepository;
private final HomeUniversityQueryService homeUniversityQueryService;
private final DiscordNotifier discordNotifier;

@Transactional
public Long submitGpaScore(long siteUserId, GpaScoreRequest gpaScoreRequest, MultipartFile file) {
Expand All @@ -46,6 +49,7 @@ public Long submitGpaScore(long siteUserId, GpaScoreRequest gpaScoreRequest, Mul
Gpa gpa = new Gpa(gpaScoreRequest.gpa(), gpaScoreRequest.gpaCriteria(), uploadedFile.fileUrl());
GpaScore newGpaScore = new GpaScore(gpa, siteUser);
GpaScore savedNewGpaScore = gpaScoreRepository.save(newGpaScore);
discordNotifier.notify(DiscordNotificationType.GPA_SCORE, siteUser.getNickname());

@coderabbitai coderabbitai Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Find candidate service files:\n'
fd -a 'ScoreService\.java|MentorApplicationService\.java|ReportService\.java|.*Notifier.*\.java|.*Notification.*\.java|.*Listener.*\.java|.*Async.*\.java' src/main/java 2>/dev/null | sed 's#^\./##' || true

printf '\nScoreService outline/contents:\n'
ast-grep outline src/main/java/com/example/solidconnection/score/service/ScoreService.java 2>/dev/null || true
cat -n src/main/java/com/example/solidconnection/score/service/ScoreService.java

printf '\nMentorApplicationService outline/contents:\n'
ast-grep outline src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java 2>/dev/null || true
cat -n src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java

printf '\nReportService outline/contents:\n'
ast-grep outline src/main/java/com/example/solidconnection/report/service/ReportService.java 2>/dev/null || true
cat -n src/main/java/com/example/solidconnection/report/service/ReportService.java

printf '\nSearch for DiscordNotifier implementation and async/disk notification handling:\n'
rg -n "interface DiscordNotifier|class .*Discord|notify\\(|`@Async`|ApplicationEvent|AFTER_COMMIT|TransactionSynchronizationManager|TransactionManager|EventPublisher|save\\(" src/main/java src/test/java 2>/dev/null | head -n 200

Repository: solid-connection/solid-connect-server

Length of output: 38630

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'DiscordNotifier implementation:\n'
cat -n src/main/java/com/example/solidconnection/common/discord/DiscordNotifier.java

printf '\nAsync transactional configuration:\n'
cat -n src/main/java/com/example/solidconnection/common/config/sync/AsyncConfig.java

printf '\nStatic verifier: direct Discord notifier calls from `@Transactional` save paths:\n'
python3 - <<'PY'
from pathlib import Path
import re

targets = [
    ('src/main/java/com/example/solidconnection/score/service/ScoreService.java', [52, 65]),
    ('src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java', [66]),
    ('src/main/java/com/example/solidconnection/report/service/ReportService.java', [45]),
]
notifier = Path('src/main/java/com/example/solidconnection/common/discord/DiscordNotifier.java').read_text()

for file, lines in targets:
    src = Path(file).read_text().splitlines()
    in_transactional = False
    for i, line in enumerate(src, 1):
        if '`@Transactional`' in line:
            in_transactional = True
        if i in lines:
            call = line.strip()
            print(f'{file}:{i}: transactional_context={in_transactional} call={call}')
        if 'public ' in line and 'void' in line or (i in lines and in_transactional):
            in_transactional = 'return' not in line or 'void' not in line

has_async_notify = bool(re.search(r'@\s*Async[\s\n]*public\s+void\s+notify\b', notifier))
has_spring_async_annotation = bool(re.search(r'org\.springframework\..scheduling\.\w+\.annotation\.\s*`@Async`', Path('pom.xml').read_text() if Path('pom.xml').exists() else ''))
print(f'DiscordNotifier.notify is `@Async`={has_async_notify}')
print(f'Service paths dispatch outside transaction commit boundary; Spring `@Async` tasks queued while current request path returns before notification completion.')
PY

Repository: solid-connection/solid-connect-server

Length of output: 4433

1. Discord 알림 트랜잭션 커밋과 분리하세요.

네 위치 모두 @Async DiscordNotifier.notify가 @Transactional save 후에 실행됩니다. 기존 등록/수정/삭제가 rollback되면 알림이 누락되거나, 실제 데이터 링크는 커밋이 완성되지 않은 상태로 전송될 수 있습니다. transaction event를 AFTER_COMMIT에서 처리하거나 outbox로 저장 후 발송하세요.

- src/main/java/com/example/solidconnection/score/service/ScoreService.java#L52: GPA 알림을 커밋 이후 이벤트로 변경하세요.
- src/main/java/com/example/solidconnection/score/service/ScoreService.java#L65: 어학 성적 알림을 커밋 이후 이벤트로 변경하세요.
- src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java#L66: 멘토 지원 알림을 커밋 이후 이벤트로 변경하세요.
- src/main/java/com/example/solidconnection/report/service/ReportService.java#L45: 신고 알림을 커밋 이후 이벤트로 변경하세요.

[low Effort_and_high_reward]

📍 Affects 3 files
  • src/main/java/com/example/solidconnection/score/service/ScoreService.java#L52-L52 (this comment)
  • src/main/java/com/example/solidconnection/score/service/ScoreService.java#L65-L65
  • src/main/java/com/example/solidconnection/mentor/service/MentorApplicationService.java#L66-L66
  • src/main/java/com/example/solidconnection/report/service/ReportService.java#L45-L45
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/example/solidconnection/score/service/ScoreService.java` at
line 52, Move the Discord notification calls to transaction-commit event
handling so they execute only after the surrounding save transaction
successfully commits, preserving the existing notification types and recipients:
update ScoreService.java lines 52-52 and 65-65, MentorApplicationService.java
line 66-66, and ReportService.java line 45-45. Use an AFTER_COMMIT transaction
event or an equivalent outbox flow, and do not invoke DiscordNotifier.notify
directly within the transactional methods.

return savedNewGpaScore.getId();
}

Expand All @@ -58,6 +62,7 @@ public Long submitLanguageTestScore(long siteUserId, LanguageTestScoreRequest la
languageTestScoreRequest.languageTestScore(), uploadedFile.fileUrl());
LanguageTestScore newScore = new LanguageTestScore(languageTest, siteUser);
LanguageTestScore savedNewScore = languageTestScoreRepository.save(newScore);
discordNotifier.notify(DiscordNotificationType.LANGUAGE_TEST_SCORE, siteUser.getNickname());
return savedNewScore.getId();
}

Expand Down
Loading