🐛 어드민 인증 토큰 흐름 분리 - #613
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (2)
Walkthrough
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68456d277c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,37 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Split the unrelated web cleanup into an atomic commit
When this authentication change must be reverted or cherry-picked, deleting the deprecated web utility is forced to travel with the admin endpoint and storage-key changes even though the repository-wide search shows it is unrelated cleanup. Move this deletion to its own commit so each commit contains one logical change as required by the repository convention.
AGENTS.md reference: AGENTS.md:L86-L86
Useful? React with 👍 / 👎.
관련 이슈
작업 내용
accessToken→adminAccessToken으로 변경했습니다. 서버가 어드민 refresh token 쿠키/Redis 키를adminProdRefreshToken/ADMIN_REFRESH로 분리한 것과 네이밍을 맞추기 위함이며, 별도 마이그레이션 shim은 두지 않았습니다(어드민 사용자가 소수라 재로그인 비용을 허용).admin.solid-connection.com과solid-connection.com간에 실제로 값이 공유되는 위험은 없었습니다. 이번 변경은 유출 위험 제거가 아니라 서버 네이밍과의 일관성 확보 및accessToken리터럴 혼동 제거가 목적입니다.apps/web/src/utils/localStorageUtils.ts를 삭제했습니다(저장소 전체에서 import하는 곳이 없음을 확인).특이 사항
리뷰 요구사항 (선택)
검증