Skip to content

πŸ› 지원 λŒ€ν•™ 관리 검색 μ‹œ κ΅­λ‚΄ λŒ€ν•™/ν•™κΈ° ν•„ν„° 미적용 버그 μˆ˜μ • - #617

Merged
whqtker merged 1 commit into
mainfrom
fix/admin-univ-apply-search-filter
Aug 1, 2026
Merged

πŸ› 지원 λŒ€ν•™ 관리 검색 μ‹œ κ΅­λ‚΄ λŒ€ν•™/ν•™κΈ° ν•„ν„° 미적용 버그 μˆ˜μ •#617
whqtker merged 1 commit into
mainfrom
fix/admin-univ-apply-search-filter

Conversation

@whqtker

@whqtker whqtker commented Aug 1, 2026

Copy link
Copy Markdown
Member

μš”μ•½

  • μ–΄λ“œλ―Ό 지원 λŒ€ν•™ 관리 νƒ­μ—μ„œ κ΅­λ‚΄ λŒ€ν•™Β·ν•™κΈ°λ₯Ό 선택해 κ²€μƒ‰ν•˜λ©΄, 응닡은 μ •μƒμœΌλ‘œ μ˜€μ§€λ§Œ ν™”λ©΄μ—λŠ” κ²°κ³Όκ°€ ν‘œμ‹œλ˜μ§€ μ•ŠλŠ” 문제 μˆ˜μ •
  • adminApi.searchUnivApplyInfosκ°€ 검색어(value)만 μ„œλ²„λ‘œ μ „μ†‘ν•˜κ³  homeUniversityId/termIdλŠ” 보내지 μ•Šμ•„, μ„œλ²„κ°€ 항상 ν˜„μž¬ ν•™κΈ° κΈ°μ€€μœΌλ‘œλ§Œ μ‘λ‹΅ν•˜κ³  μžˆμ—ˆμŒ
  • 응닡을 λ‹€μ‹œ μ„ νƒν•œ ν•™κΈ° 라벨과 비ꡐ해 ν΄λΌμ΄μ–ΈνŠΈμ—μ„œ ν•„ν„°λ§ν•˜λ˜ 둜직 λ•Œλ¬Έμ—, ν˜„μž¬ ν•™κΈ°κ°€ μ•„λ‹Œ ν•™κΈ°λ₯Ό μ„ νƒν•˜λ©΄ 응닡에 데이터가 μžˆμ–΄λ„ μ „λΆ€ 걸러져 ν™”λ©΄μ—λŠ” 아무것도 μ•ˆ λ³΄μ˜€μŒ
  • homeUniversityId/termIdλ₯Ό μ‹€μ œλ‘œ μ„œλ²„μ— μ „λ‹¬ν•˜λ„λ‘ μˆ˜μ •ν•˜κ³ , μ„œλ²„κ°€ 이미 ν•„ν„°λ§ν•˜λ―€λ‘œ λΆˆν•„μš”ν•΄μ§„ ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ μž¬ν•„ν„°λ§ 둜직 제거

ν…ŒμŠ€νŠΈ ν”Œλžœ

  • pnpm --filter admin typecheck, lint:check 톡과 (컀밋 μ‹œ CI parity ν›…μœΌλ‘œ 확인)
  • 둜컬 MySQL/Redis + λ°±μ—”λ“œ(local ν”„λ‘œν•„)λ₯Ό 직접 λ„μš°κ³ , λΉ„ν˜„μž¬ ν•™κΈ° 데이터λ₯Ό μ‹œλ“œν•œ λ’€ API λ ˆλ²¨μ—μ„œ μˆ˜μ • μ „/ν›„ λ™μž‘ 차이λ₯Ό 직접 μž¬ν˜„Β·κ²€μ¦ν•¨
    • μˆ˜μ • μ „ μž¬ν˜„(νŒŒλΌλ―Έν„° 미전솑): 응닡은 μ •μƒμ΄μ§€λ§Œ 항상 ν˜„μž¬ ν•™κΈ° λ°μ΄ν„°λ§Œ λ°˜ν™˜ β†’ ν”„λ‘ νŠΈ ν•„ν„°κ°€ 이λ₯Ό μ „λΆ€ κ±ΈλŸ¬λ‚΄ 빈 ν™”λ©΄
    • μˆ˜μ • ν›„(νŒŒλΌλ―Έν„° 전솑): μ„ νƒν•œ ν•™κΈ°μ˜ 데이터가 μ •ν™•νžˆ λ°˜ν™˜λ¨
  • admin ν™”λ©΄μ—μ„œ 직접 클릭 ν…ŒμŠ€νŠΈλŠ” λͺ» 함 β€” 둜컬 admin dev μ„œλ²„(vinext)κ°€ 이 λ³€κ²½κ³Ό λ¬΄κ΄€ν•œ κΈ°μ‘΄ 이슈둜 dev λͺ¨λ“œμ—μ„œ 500 μ—λŸ¬λ₯Ό λ°˜ν™˜ν•΄ μ‹€μ œ ν™”λ©΄ 확인이 λ§‰ν˜€ μžˆμ—ˆμŒ (ν”„λ‘œλ•μ…˜ λΉŒλ“œλŠ” 정상 μ™„λ£Œλ¨)

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
https://claude.ai/code/session_01EwpgqdNTrn8dGDr7g7WnYg

searchUnivApplyInfosκ°€ κ²€μƒ‰μ–΄λ§Œ μ„œλ²„λ‘œ 보내고 homeUniversityId/termIdλ₯Ό
μ „λ‹¬ν•˜μ§€ μ•Šμ•„, μ„œλ²„κ°€ 항상 ν˜„μž¬ ν•™κΈ° κΈ°μ€€μœΌλ‘œ μ‘λ‹΅ν–ˆλ‹€. 응닡을 λ‹€μ‹œ
μ„ νƒν•œ ν•™κΈ° 라벨과 비ꡐ해 ν΄λΌμ΄μ–ΈνŠΈμ—μ„œ ν•„ν„°λ§ν•˜λ˜ 둜직 λ•Œλ¬Έμ— ν˜„μž¬
ν•™κΈ°κ°€ μ•„λ‹Œ ν•™κΈ°λ₯Ό μ„ νƒν•˜λ©΄ κ²°κ³Όκ°€ μžˆμ–΄λ„ ν™”λ©΄μ—λŠ” 아무것도 ν‘œμ‹œλ˜μ§€
μ•Šμ•˜λ‹€.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwpgqdNTrn8dGDr7g7WnYg
@whqtker
whqtker requested review from manNomi and wibaek as code owners August 1, 2026 14:35
@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview Aug 1, 2026 2:36pm
solid-connect-web-admin Ready Ready Preview Aug 1, 2026 2:36pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connection-web Skipped Skipped Aug 1, 2026 2:36pm

@github-actions github-actions Bot added the admin label Aug 1, 2026
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

  1. 검색 API 쑰건 ν™•μž₯
    검색 APIκ°€ 검색어, κ΅­λ‚΄ λŒ€ν•™ ID, ν•™κΈ° IDλ₯Ό 객체둜 λ°›μ•„ 쿼리 νŒŒλΌλ―Έν„°λ‘œ μ „λ‹¬ν•©λ‹ˆλ‹€.

  2. 관리 νƒ­ 검색 연동 λ³€κ²½
    관리 탭이 μ„Έ 검색 쑰건을 API에 μ „λ‹¬ν•©λ‹ˆλ‹€. API μ‘λ‹΅μ˜ univApplyInfoPreviewsλ₯Ό 직접 μ‚¬μš©ν•©λ‹ˆλ‹€.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: wibaek, mannomi

πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
βœ… Passed checks (4 passed)
Check name Status Explanation
Title check βœ… Passed 제λͺ©μ€ κ΅­λ‚΄ λŒ€ν•™ 및 ν•™κΈ° ν•„ν„° 미적용 버그 μˆ˜μ •μ΄λΌλŠ” PR의 μ£Όμš” λ³€κ²½ 사항을 μ •ν™•νžˆ μ„€λͺ…ν•©λ‹ˆλ‹€.
Description check βœ… Passed μ„€λͺ…은 문제 원인, μˆ˜μ • λ‚΄μš©, ν…ŒμŠ€νŠΈ 결과와 λ―Έμˆ˜ν–‰ν•œ ν™”λ©΄ ν…ŒμŠ€νŠΈλ₯Ό ꡬ체적으둜 ν¬ν•¨ν•©λ‹ˆλ‹€.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches πŸ’‘ 1
πŸ“ Generate docstrings πŸ’‘
  • Create stacked PR
  • Commit on current branch
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/admin-univ-apply-search-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
apps/admin/src/lib/api/admin.ts (1)

373-380: πŸ—„οΈ Data Integrity & Integration | πŸ”΅ Trivial | ⚑ Quick win

1. μ„Έ 검색 쑰건의 전달을 νšŒκ·€ ν…ŒμŠ€νŠΈλ‘œ κ³ μ •ν•΄ μ£Όμ„Έμš”.

searchUnivApplyInfos의 계약이 value 단일 κ°’μ—μ„œ μ„Έ ν•„λ“œλ‘œ λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€. apps/admin/src/lib/api/admin.test.ts에 value, homeUniversityId, termIdκ°€ /univ-apply-infos/search/text의 params에 λͺ¨λ‘ μ „λ‹¬λ˜λŠ”μ§€ ν™•μΈν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•΄ μ£Όμ„Έμš”. ν–₯ν›„ ν•„ν„° λˆ„λ½ νšŒκ·€λ₯Ό λΉ λ₯΄κ²Œ λ°œκ²¬ν•  수 μžˆμŠ΅λ‹ˆλ‹€.

πŸ€– Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/admin/src/lib/api/admin.ts` around lines 373 - 380, In the admin API
tests, add a regression test for searchUnivApplyInfos that invokes it with
value, homeUniversityId, and termId, then verifies the GET request to
"/univ-apply-infos/search/text" includes all three fields in params.
πŸ€– Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@apps/admin/src/lib/api/admin.ts`:
- Around line 373-380: In the admin API tests, add a regression test for
searchUnivApplyInfos that invokes it with value, homeUniversityId, and termId,
then verifies the GET request to "/univ-apply-infos/search/text" includes all
three fields in params.

ℹ️ Review info
βš™οΈ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 817888a8-76a9-4576-97c1-90d6cc45156d

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 3c663ae and 9308510.

πŸ“’ Files selected for processing (2)
  • apps/admin/src/components/features/univ-apply-infos/tabs/UnivApplyInfoManageTab.tsx
  • apps/admin/src/lib/api/admin.ts

@whqtker
whqtker merged commit 43e57e3 into main Aug 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant