Skip to content

fix: remove constructor from number_of_parameters rule - #335

Merged
solid-illiaaihistov merged 1 commit into
solid-software:masterfrom
solid-illiaaihistov:fix/ignore-constructors-in-number-of-parameters
Jul 28, 2026
Merged

fix: remove constructor from number_of_parameters rule#335
solid-illiaaihistov merged 1 commit into
solid-software:masterfrom
solid-illiaaihistov:fix/ignore-constructors-in-number-of-parameters

Conversation

@solid-illiaaihistov

@solid-illiaaihistov solid-illiaaihistov commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Updated the parameter-count lint to check only functions and methods.
    • Constructors with more parameters than the configured limit are no longer flagged.
  • Tests
    • Updated lint coverage to confirm constructors produce no diagnostics.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 91f6f9cd-a846-4482-a44e-5c1c342a7f77

📥 Commits

Reviewing files that changed from the base of the PR and between a6d4ae1 and 0d823a5.

📒 Files selected for processing (3)
  • lib/src/lints/number_of_parameters/number_of_parameters_rule.dart
  • lib/src/lints/number_of_parameters/visitors/number_of_parameters_visitor.dart
  • test/src/lints/number_of_parameters/number_of_parameters_rule_test.dart

📝 Walkthrough

Walkthrough

The number-of-parameters lint now checks only functions and methods. Constructor registration and visitor handling were removed, descriptions were updated, and constructor tests now expect no diagnostics.

Changes

Number-of-parameters lint scope

Layer / File(s) Summary
Restrict parameter checks to functions and methods
lib/src/lints/number_of_parameters/..., test/src/lints/number_of_parameters/number_of_parameters_rule_test.dart
The rule and visitor no longer process constructors, documentation reflects the narrower scope, and constructor tests assert no diagnostics.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: constructors are removed from the number_of_parameters rule.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@solid-illiaaihistov
solid-illiaaihistov merged commit ebfd8f2 into solid-software:master Jul 28, 2026
2 checks passed
@solid-illiaaihistov
solid-illiaaihistov deleted the fix/ignore-constructors-in-number-of-parameters branch July 28, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants