Fix 0.7.0 error#24
Merged
Merged
Conversation
Contributor
Author
|
This is currently a "beat with blunt object" fix for #23 |
Contributor
|
Hey @junderw, thanks for this! I think this fix should be enough. So far this parser doesn't do different things for different versions: it's built to accept any valid solidity code for any version. This means that sometimes it can parse solidity code that won't compile, but that's fine for most use cases. Can you remove the comment and add some tests for this? |
Contributor
Author
|
I removed the comment and added a test to confirm the no-keyword case has visibility of public. |
Contributor
|
Thanks @junderw! |
Contributor
|
Just published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there a way to get the pragma setting?