enhancement: adding firstIndex and lastIndex to virtual#979
Conversation
🦋 Changeset detectedLatest commit: 66bd829 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
: addedfirstIndex: numberandlastIndex: number | undefinedtoVirtualListReturn's type and the returned object.lastIndexislastIdx - 1(since slicing is exclusive) andundefined` for an empty list.packages/virtual/test/index.test.tsx: added the equivalent test cases from the PR (basic values, scroll updates, overscan, bottom-of-list, empty list, singleton list), adapted to this repo'screateRoot/flushtest pattern for Solid 2.0.patchbump for@solid-primitives/virtual).